[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/alderlake/chip.h: Use boolean type where applicable

[Felix Singer (Code Review)]

Attention is currently required from: Michael Strosche, Paul Menzel, Subrata Banik, Tarun Tuli.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76830?usp=email )

Change subject: soc/intel/alderlake/chip.h: Use boolean type where applicable
......................................................................

Patch Set 1: Code-Review+1

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/76830/comment/51a9ed08_cedd3cf3 :
PS1, Line 8:
> Please elaborate, and mention the motivation. […]

The devicetrees don't need to be changed. true and false are just pp defines.

Patchset:

PS1: 
Looks pretty good!

File src/soc/intel/alderlake/chip.h:

https://review.coreboot.org/c/coreboot/+/76830/comment/b2f0208f_dac58b79 :
PS1, Line 343: uint8_t
bool

https://review.coreboot.org/c/coreboot/+/76830/comment/d52daa52_5279edf8 :
PS1, Line 463: 	uint8_t skip_ext_gfx_scan;
That should be bool. While on it, please add a line before this and the enum

https://review.coreboot.org/c/coreboot/+/76830/comment/dd066ea8_ec6e9a1b :
PS1, Line 482: /*
             : 	 * GSPIn Default Chip Select Mode:
             : 	 * 0:Hardware Mode,
             : 	 * 1:Software Mode
             : 	 */
             : 	bool serial_io_gspi_cs_mode[CONFIG_SOC_INTEL_COMMON_BLOCK_GSPI_MAX];
             : 	/*
             : 	 * GSPIn Default Chip Select State:
             : 	 * 0: Low,
             : 	 * 1: High
             : 	 */
             : 	bool serial_io_gspi_cs_state[CONFIG_SOC_INTEL_COMMON_BLOCK_GSPI_MAX];
These could be a bool, but with the current attribute names it would be rather confusing. So we would need to change them. However, I think using enum values would be better here and this should stay uint8_t.