Attention is currently required from: Da Lao, Forkoz.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40723/comment/dbb0ff37_88cb3735
PS3, Line 14: solve
Done
Should be good enough, though the build failure looks odd.
In case you didn't know yet: our gerrit guidelines [1] say "don't modify other people's patches without their consent". As this change is not part of a patch train and has been sitting here for about 10 months without any updates, that you've updated its commit message is not a big deal. Still, please keep this in mind in the future.
[1]: https://doc.coreboot.org/getting_started/gerrit_guidelines.html
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40723
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8669b8de6fa0801e261138651b8b2cf50432a70
Gerrit-Change-Number: 40723
Gerrit-PatchSet: 4
Gerrit-Owner: Da Lao
dalao@tutanota.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Forkoz
Crabstorage@getbackinthe.kitchen
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Da Lao
dalao@tutanota.com
Gerrit-Attention: Forkoz
Crabstorage@getbackinthe.kitchen
Gerrit-Comment-Date: Wed, 03 Mar 2021 20:13:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Forkoz
Crabstorage@getbackinthe.kitchen
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment