build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31863 )
Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2 ......................................................................
Patch Set 1:
(10 comments)
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c@551 PS1, Line 551: u16 __weak smbios_processor_core_count(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c@564 PS1, Line 564: trailing whitespace
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c@568 PS1, Line 568: u16 __weak smbios_processor_thread_count(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c@571 PS1, Line 571: trailing whitespace
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c@571 PS1, Line 571: please, no spaces at the start of a line
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c@581 PS1, Line 581: trailing whitespace
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c@612 PS1, Line 612: if (core_count > 255) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c@615 PS1, Line 615: } else { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c@619 PS1, Line 619: if (thread_count > 255) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/31863/1/src/arch/x86/smbios.c@622 PS1, Line 622: } else { suspect code indent for conditional statements (8, 10)