Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41069 )
Change subject: soc/amd/common/block/lpc: Add config options for eSPI ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41069/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/Kconfig:
https://review.coreboot.org/c/coreboot/+/41069/1/src/soc/amd/common/block/lp... PS1, Line 19: Select this option if mainboard uses eSPI instead of LPC (if supported
I agree with Felix, we should cleanly support both espi and lpc. […]
Thanks Raul. I see you updated your patchset. I can rebase on top of that and rework this series to make lpc and espi work together.
About eSPI config, for now I am thinking to keep it in SoC config just like all other IP configs. We can revisit all those configs at once to see if it makes sense to add chip drivers for each of the devices and move them under the device.