[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: add NULL-pointer check to root_complex_fill_ssdt

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42846 )

Change subject: soc/amd/picasso: add NULL-pointer check to root_complex_fill_ssdt
......................................................................

soc/amd/picasso: add NULL-pointer check to root_complex_fill_ssdt

Found-by: Coverity CID 1429980

Change-Id: Ia72b9dbe029a5da98e408a9cf16fa4a93b10917a
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42846
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
Reviewed-by: Raul Rangel 
---
M src/soc/amd/picasso/root_complex.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved
  Raul Rangel: Looks good to me, approved

diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c
index 4930a0e..036ff00 100644
--- a/src/soc/amd/picasso/root_complex.c
+++ b/src/soc/amd/picasso/root_complex.c
@@ -135,6 +135,12 @@
 {
    msr_t msr;

+	if (!device) {
+		printk(BIOS_ERR, "%s: device is NULL! ACPI SSDT will be incomplete.\n",
+			__func__);
+		return;
+	}
+
    acpigen_write_scope(acpi_device_scope(device));

msr = rdmsr(TOP_MEM);