16 Jul
2021
16 Jul
'21
1:48 a.m.
Attention is currently required from: Nico Huber, Michał Żygowski, Marshall Dawson, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56062 )
Change subject: libpayload: Continue in ahci_cmdslot_exec() despite unset HBA_PxCMD_CR ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: I skimmed the AHCI 1.3.1 specification, and couldn’t find the section asking for this check. So maybe it can be fully removed?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56062
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b94cf4aa40dce587f52350ff4624946aeaafcc0
Gerrit-Change-Number: 56062
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 16 Jul 2021 08:48:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment