Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42362 )
Change subject: ACPI: Replace smm_setup_structures() ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42362/9/src/cpu/x86/smm/smi_trigger... File src/cpu/x86/smm/smi_trigger.c:
https://review.coreboot.org/c/coreboot/+/42362/9/src/cpu/x86/smm/smi_trigger... PS9, Line 47: void set_smm_gnvs_ptr(void) Why is this exposed as a global if there's only one caller?