Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31529 )
Change subject: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake
......................................................................
Patch Set 3:
@Nico/Patrick: Can you please reconsider your -1 on this CL?
Why? A -1 merely states that we'd prefer something else. It's
no problem to merge something with -1, especially not in a
situation like this with FSP involved. I assume that you have
to work with what you get from the people building FSP.
If you want, you can take the -1 as a reminder to tell those
people that they are dragging Intel down. (I mean, if I built
something with the wrong numbers, I'd just rebuild it when
somebody tells me about it. But that'd probably just be me.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31529
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I734316445dda5b1feb4098ce3c58b6dd8ce2d272
Gerrit-Change-Number: 31529
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Feb 2019 09:40:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment