Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76016?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DisableHeciRetry dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DisableHeciRetry dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="DisableHeciRetry" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I395b9cfe02fe1b98e3948e0a516341697f0bb51d Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/prodrive/hermes/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/76016/1
diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb index 8bf05d4..dd585cc 100644 --- a/src/mainboard/prodrive/hermes/devicetree.cb +++ b/src/mainboard/prodrive/hermes/devicetree.cb @@ -134,7 +134,7 @@ [PchSerialIoIndexUART2] = PchSerialIoPci, }"
- register "DisableHeciRetry" = "1" + register DisableHeciRetry = true
device cpu_cluster 0 on end