[coreboot-gerrit] Change in coreboot[master]: treewide: Remove unused spinlock functions

[Raul Rangel (Code Review)]

Attention is currently required from: Jason Glenesk, Nico Huber, Marshall Dawson, Julius Werner, Kyösti Mälkki, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59020 )

Change subject: treewide: Remove unused spinlock functions
......................................................................

Patch Set 2:

(3 comments)

File src/arch/x86/include/arch/smp/spinlock.h:

https://review.coreboot.org/c/coreboot/+/59020/comment/09cf1c28_4d077768 
PS2, Line 31: #define barrier() __asm__ __volatile__("" : : : "memory")
> static void phys_memory_barrier(void)  in lib/ramtest.c […]

In CB:43810 you said it doesn't belong here. If we want to clean up those other ones we can IMO do it in a separate CL.

File src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h:

https://review.coreboot.org/c/coreboot/+/59020/comment/a39f1509_76d2c996 
PS2, Line 8: #define spin_unlock(lock)	do {} while (0)
> We enter this file undef CONFIG(SMP) so these are not really acceptable. […]

We could change the guard to `CONFIG(SMP) && ENV_RAMSTAGE`.

https://review.coreboot.org/c/coreboot/+/59020/comment/b9fddca1_5f63224c 
PS2, Line 11: #define boot_cpu() 1
> Why does spinlock.h have #include <smp/node.h> at the end? […]

no idea. this was copied from the arm spinlock.h.