Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45794 )
Change subject: soc/intel/common/block/pmc: Add PMC API for low power programming
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45794/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/pmc/Kconfig:
https://review.coreboot.org/c/coreboot/+/45794/6/src/soc/intel/common/block/...
PS6, Line 36: Enable this for PMC devices to perform registers programming
: to ensure low power in active idle scenario.
:
if FSP fails to do so, coreboot still has means to handle it. […]
see https://review.coreboot.org/q/topic:%22intel_pm_acpi_timer%22
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I017ddc772f02ccba889d316319ab3d5626b80ba5
Gerrit-Change-Number: 45794
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Sun, 04 Oct 2020 14:00:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subi.banik@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment