Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35459 )
Change subject: mb/google/hatch: Remove GPIO_DRIVER from pen eject GPIO configuration ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35459/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35459/1//COMMIT_MSG@18 PS1, Line 18: . What about S3? That should work too.
https://review.coreboot.org/c/coreboot/+/35459/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/35459/1/src/mainboard/google/hatch/... PS1, Line 34: PAD_CFG_GPI_SCI Just a note: If any variants were relying on this pin for OS notifications, then that wouldn't work anymore. It would be good to confirm that all variants have this dual-routed. And add the other pin for OS notifications.
https://review.coreboot.org/c/coreboot/+/35459/1/src/mainboard/google/hatch/... PS1, Line 34: LEVEL This needs to be EDGE_SINGLE. Else, the device will wake up whenever the pen is left in the garage.