Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33434 )
Change subject: soc/intel/skylake/romstage: Increase size of postcar stack ......................................................................
Patch Set 2:
Patch Set 2:
Should we maybe think about using a different submission method? I always find it a little jarring that a patch just gets instantly merged at the push of a button with no warning. In Chromium OS, we have submission tied to the CI system, so the author sets a "Commit-Ready" flag in Gerrit and after a couple of hours the CI system will merge it... gives other people a chance to say "wait, no!".
We have the 24h waiting period defined in our Gerrit guidelines anyway. How about we add a Commit-Ready flag that's set by the author and a simple bot that will merge all CLs after that flag has been set for 24 hours (and that have a +2, a Verified+1 and no -2, or maybe even no -1)? With that we could maybe also open up submission to more people (it's currently very restricted) and save Patrick the time to always do this manually. (Manual submissions could still be available to core developers for emergency reverts and the like.)
I am afraid I don't understand how this would have helped here. The change was submitted after about two days of inactivity, without any negative code-review scores. Wouldn't the bot have submitted the change right away, even if there are unresolved comments?
IMHO, the -1 is used too little. It's a very nice balance - doesn't block, but is visible right away (red sticks out significantly). Sure, it is "volatile" (gets lost on a new patchset), but so is a +2.