Sathya Prakash M R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31280 )
Change subject: mb/google/hatch: Enable audio support ......................................................................
Patch Set 7:
(5 comments)
Fixed comments in v6.
https://review.coreboot.org/#/c/31280/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31280/6/src/mainboard/google/hatch/variants/... PS6, Line 248: register "probed" = "1"
This is not required.
Done
https://review.coreboot.org/#/c/31280/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31280/6/src/mainboard/google/hatch/variants/... PS6, Line 344: /* : * AUDIO IRQ : * TODO Configure it back to invert mode, when : * ITSS IPCx configuration is fixed in FSP. : */ : PAD_CFG_GPI_APIC(GPP_H0, NONE, PLTRST, LEVEL, NONE),
This is already done in line 364
Done
https://review.coreboot.org/#/c/31280/6/src/mainboard/google/hatch/variants/... PS6, Line 351: PAD_CFG_GPO(GPP_H3, 0, DEEP),
This is already done in line 370
Done
https://review.coreboot.org/#/c/31280/6/src/mainboard/google/hatch/variants/... PS6, Line 353: PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1), : /* DMIC_DATA_0_SNDW4_DATA */ : PAD_CFG_NF(GPP_D20, NONE, DEEP, NF1),
This is already done in line 216-218
Done
https://review.coreboot.org/#/c/31280/6/src/mainboard/google/hatch/variants/... PS6, Line 357: PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
This is already done in line 228
Done