Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34754 )
Change subject: soc/intel/cannonlake: Add provision to skip postcar and load ramstage
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34754/4/src/soc/intel/cannonlake/ro...
File src/soc/intel/cannonlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/34754/4/src/soc/intel/cannonlake/ro...
PS4, Line 133: * and car tear down will be handled by ramstage at its entry.
So what are the timings like for postcar loading doing this? Why wouldn't this be unconditional just […]
i can try this and let you know by tomorrow ? this should provide some savings for sure
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34754
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f1d93ae0f8d957bf9c15e358bc13039a300c4ca
Gerrit-Change-Number: 34754
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Aug 2019 14:52:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment