Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42976 )
Change subject: mb/ocp/deltalake: Unset POWER_STATE_DEFAULT_ON_AFTER_FAILURE
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42976/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42976/5//COMMIT_MSG@7
PS5, Line 7: Deselect
Maybe use *Unset*, as that is what Kconfig uses?
Done
https://review.coreboot.org/c/coreboot/+/42976/5//COMMIT_MSG@7
PS5, Line 7: /mb/ocp/deltalake: Deselect POWER_STATE_DEFAULT_ON_AFTER_FAILURE
Please remove the / in the start.
Done
https://review.coreboot.org/c/coreboot/+/42976/5//COMMIT_MSG@14
PS5, Line 14: select
be selected
Done
https://review.coreboot.org/c/coreboot/+/42976/5//COMMIT_MSG@17
PS5, Line 17: select CPU_INTEL_COMMON_SMM
Please also indent with a tab.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d4f14bdfc18740976171fd5d369b2d79a916dc4
Gerrit-Change-Number: 42976
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: Rocky Phagura
Gerrit-CC: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Comment-Date: Mon, 13 Jul 2020 08:25:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment