Attention is currently required from: Ravi kumar, Sudheer Amrabadi, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61342 )
Change subject: qualcomm/sc7280: Add support for edp and mdp driver ......................................................................
Patch Set 10: Verified+1
(2 comments)
File src/mainboard/google/herobrine/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140172): https://review.coreboot.org/c/coreboot/+/61342/comment/bf3bd620_b0f3a438 PS10, Line 61: if (display_init_required()) { suspect code indent for conditional statements (8, 24)
File src/soc/qualcomm/sc7280/display/edp_ctrl.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140172): https://review.coreboot.org/c/coreboot/+/61342/comment/e0fd502b_082b74c7 PS10, Line 863: ret = edp_start_link_train_2(ctrl,dpcd); space required after that ',' (ctx:VxV)