2 Aug
2019
2 Aug
'19
5:29 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34510 )
Change subject: security/vboot: Add Support for Intel PTT ......................................................................
Patch Set 23: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34510/23/src/security/vboot/tpm_com... File src/security/vboot/tpm_common.c:
https://review.coreboot.org/c/coreboot/+/34510/23/src/security/vboot/tpm_com... PS23, Line 19: TPM_PCR_GBB_FLAGS_NAME nit: please change the constant name as well (also, maybe "VBOOT: boot mode" and "VBOOT: GBB HWID" would go better with the way the other TCPA entries are usually named?)
--
To view, visit https://review.coreboot.org/c/coreboot/+/34510
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c9a839f53f96506be5fb68f7c1ed5bf6692505
Gerrit-Change-Number: 34510
Gerrit-PatchSet: 23
Gerrit-Owner: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 03 Aug 2019 00:29:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment