Attention is currently required from: Jonathan Zhang, Jay Talbott, Stefan Reinauer.
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57561 )
Change subject: Documentation: Add OCP Mono Lake mainboard
......................................................................
Patch Set 2:
(3 comments)
File Documentation/mainboard/ocp/monolake.md:
https://review.coreboot.org/c/coreboot/+/57561/comment/d96a90a1_fd36eb5f
PS1, Line 23: Mono Lake coreboot
Is this line needed?
Done
https://review.coreboot.org/c/coreboot/+/57561/comment/11c56024_da6e6e55
PS1, Line 28: - [FSP] blob: Broadwell-DE FSP v1.0
The SysPro custom FSP is required to support the 16-core Broadwell-DE SKU in the Mono Lake, as the I […]
Done
https://review.coreboot.org/c/coreboot/+/57561/comment/a9588913_2ba51c9a
PS1, Line 135: | BMC | Aspeed AST 1250 |
There is a misalignment here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: I2109cca0e4037a2945bcb7e4d80897b48ada54af
Gerrit-Change-Number: 57561
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Fri, 01 Oct 2021 21:15:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-MessageType: comment