Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@7 PS2, Line 7: kukui: Introduce a new 'Jacuzzi' family.
- Please remove the dot at the end of the commit message summary. […]
Can you elaborate more on what does that mean - common prefix different for variants?
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@11 PS2, Line 11: special : configuration
variant?
I'd prefer to not call it variant - the 'variant' has a special meaning in chromebooks referring as followers of a base board, while jacuzzi should be a new base board on its own.