Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )
Change subject: soc/intel/: Store CSE firmware version into cbmem table ......................................................................
Patch Set 8:
(2 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/1ffe2460_8ae76ff4 PS7, Line 1089: : const struct cse_bp_entry *cse_bp = cse_get_bp_entry(RW, &cse_bp_info.bp_info); : struct cse_fw_partition_info *version; : version = cbmem_add(CBMEM_ID_CSE_PARTITION_VERSION, sizeof(*version)); : version->cur_cse_fw_version.major = cse_bp->fw_ver.major; : version->cur_cse_fw_version.minor = cse_bp->fw_ver.minor; : version->cur_cse_fw_version.hotfix = cse_bp->fw_ver.hotfix; : version->cur_cse_fw_version.build = cse_bp->fw_ver.build; : } :
Can't this be handled in the cse_get_bp_info() itself? Doing so, we can avoid resending the comman […]
Make sense as per the flow. Instead of sending HECI command to get CSE Lite version, coreboot can track CSE Lite version in the metadata.
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/081996da_f1b2d87b PS8, Line 1082: SOC_INTEL_CSE_LITE_SKU This flag check is not required since the file get compiled only if SOC_INTEL_CSE_LITE_SKU config is selected.