Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47496 )
Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47496/4/src/mainboard/intel/adlrvp/...
File src/mainboard/intel/adlrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/47496/4/src/mainboard/intel/adlrvp/...
PS4, Line 270: /* CAM1_RST */
: PAD_CFG_GPO(GPP_R5, 1, PLTRST),
: /* CAM2_RST */
: PAD_CFG_GPO(GPP_E15, 1, PLTRST),
: /* CAM1_PWR_EN */
: PAD_CFG_GPO(GPP_B23, 1, PLTRST),
: /* CAM2_PWR_EN */
: PAD_CFG_GPO(GPP_E16, 1, PLTRST),
can we move this into line #74 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47496
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec
Gerrit-Change-Number: 47496
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Nov 2020 17:15:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
