[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch: Refactor override_early_gpio_table

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34782 )

Change subject: mb/google/hatch: Refactor override_early_gpio_table
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34782/4/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/hatch/gpio.c:

https://review.coreboot.org/c/coreboot/+/34782/4/src/mainboard/google/hatch/... 
PS4, Line 56: 	PAD_CFG_GPI(GPP_F2, NONE, PLTRST),
> Yes, I removed them because they are configured in platform-specific code. […]

Not using gpio_base2_value() wouldn't help since it is getting configured in gpio_input(). But, I understand your point that it is confusing to have this done in two places especially since it is using different configuration. How about adding a comment indicating why the memory straps are not configured here?