Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81565?usp=email )
Change subject: mb/google/brox: Create greenbayupoc variant ......................................................................
mb/google/brox: Create greenbayupoc variant
Create the greenbayupoc variant of the brox reference board by copying the template files to a new directory named for the variant.
BUG=b:329530883 BRANCH=None TEST=util/abuild/abuild -p none -t google/brox -x -a make sure the build includes GOOGLE_GREENBAYUPOC.
Change-Id: I90936d97b41e59c49dd92997146caf580bce1f4f Signed-off-by: Eren Peng peng.eren@inventec.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/81565 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Shelley Chen shchen@google.com --- M src/mainboard/google/brox/Kconfig M src/mainboard/google/brox/Kconfig.name A src/mainboard/google/brox/variants/greenbayupoc/include/variant/ec.h A src/mainboard/google/brox/variants/greenbayupoc/include/variant/gpio.h A src/mainboard/google/brox/variants/greenbayupoc/memory/Makefile.mk A src/mainboard/google/brox/variants/greenbayupoc/memory/dram_id.generated.txt A src/mainboard/google/brox/variants/greenbayupoc/memory/mem_parts_used.txt A src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb 8 files changed, 52 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brox/Kconfig b/src/mainboard/google/brox/Kconfig index e7f965a..9bc71ca 100644 --- a/src/mainboard/google/brox/Kconfig +++ b/src/mainboard/google/brox/Kconfig @@ -64,6 +64,9 @@ select CHROMEOS_WIFI_SAR if CHROMEOS select SOC_INTEL_STORE_ISH_FW_VERSION
+config BOARD_GOOGLE_GREENBAYUPOC + select BOARD_GOOGLE_BASEBOARD_BROX + if BOARD_GOOGLE_BROX_COMMON
config BASEBOARD_DIR @@ -114,9 +117,11 @@ config MAINBOARD_PART_NUMBER default "Brox_Ec_Ish" if BOARD_GOOGLE_BROX_EC_ISH default "Brox" if BOARD_GOOGLE_BROX + default "Greenbayupoc" if BOARD_GOOGLE_GREENBAYUPOC
config VARIANT_DIR default "brox" if BOARD_GOOGLE_BROX || BOARD_GOOGLE_BROX_EC_ISH + default "greenbayupoc" if BOARD_GOOGLE_GREENBAYUPOC
config VBOOT select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/brox/Kconfig.name b/src/mainboard/google/brox/Kconfig.name index 2ad3457..37fc310 100644 --- a/src/mainboard/google/brox/Kconfig.name +++ b/src/mainboard/google/brox/Kconfig.name @@ -7,3 +7,6 @@
config BOARD_GOOGLE_BROX_EC_ISH bool "-> Brox EC ISH" + +config BOARD_GOOGLE_GREENBAYUPOC + bool "-> Greenbayupoc" diff --git a/src/mainboard/google/brox/variants/greenbayupoc/include/variant/ec.h b/src/mainboard/google/brox/variants/greenbayupoc/include/variant/ec.h new file mode 100644 index 0000000..4fc0622 --- /dev/null +++ b/src/mainboard/google/brox/variants/greenbayupoc/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef MAINBOARD_EC_H +#define MAINBOARD_EC_H + +#include <baseboard/ec.h> + +#endif /* MAINBOARD_GPIO_H */ diff --git a/src/mainboard/google/brox/variants/greenbayupoc/include/variant/gpio.h b/src/mainboard/google/brox/variants/greenbayupoc/include/variant/gpio.h new file mode 100644 index 0000000..27c87b3 --- /dev/null +++ b/src/mainboard/google/brox/variants/greenbayupoc/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __MAINBOARD_GPIO_H__ +#define __MAINBOARD_GPIO_H__ + +#include <baseboard/gpio.h> + +#endif /* __MAINBOARD_GPIO_H__ */ diff --git a/src/mainboard/google/brox/variants/greenbayupoc/memory/Makefile.mk b/src/mainboard/google/brox/variants/greenbayupoc/memory/Makefile.mk new file mode 100644 index 0000000..eace2e4 --- /dev/null +++ b/src/mainboard/google/brox/variants/greenbayupoc/memory/Makefile.mk @@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = placeholder diff --git a/src/mainboard/google/brox/variants/greenbayupoc/memory/dram_id.generated.txt b/src/mainboard/google/brox/variants/greenbayupoc/memory/dram_id.generated.txt new file mode 100644 index 0000000..2e0f37a --- /dev/null +++ b/src/mainboard/google/brox/variants/greenbayupoc/memory/dram_id.generated.txt @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Generated by: +# ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brox/variants/brox/memory src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt + +DRAM Part Name ID to assign diff --git a/src/mainboard/google/brox/variants/greenbayupoc/memory/mem_parts_used.txt b/src/mainboard/google/brox/variants/greenbayupoc/memory/mem_parts_used.txt new file mode 100644 index 0000000..2499005 --- /dev/null +++ b/src/mainboard/google/brox/variants/greenbayupoc/memory/mem_parts_used.txt @@ -0,0 +1,11 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Generated IDs are dependent on the order of parts in this file, +# so new parts must always be added at the end of the file! +# +# Generate an updated Makefile.mk and dram_id.generated.txt by running the +# part_id_gen tool from util/spd_tools. +# See util/spd_tools/README.md for more details and instructions. + +# Part Name diff --git a/src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb b/src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb new file mode 100644 index 0000000..e707a9b --- /dev/null +++ b/src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/alderlake + + device domain 0 on + end + +end