[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer/variants/volteer: Add gpio-keys ACPI node for PENH

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43764 )

Change subject: mb/google/volteer/variants/volteer: Add gpio-keys ACPI node for PENH
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43764/5/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43764/5/src/mainboard/google/voltee... 
PS5, Line 74: EDGE_BOTH
> Well, the gpio is used to get notification of both eject and insert at runtime.

yeah, it's just confusing here when we have to select which trigger type it is. maybe there should be a DONTCARE macro too...

I think Aaron means linux does that because it assumes you want to detect both ejection & insertion at runtime.