Attention is currently required from: Felix Singer, Timofey Komarov, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52693 )
Change subject: soc/intel/skylake: Add microcodes for Coffee Lake CPUs
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52693/comment/47905a22_82d2ef70
PS5, Line 7: Coffee Lake
Rather write Amber Lake here to avoid confusions with soc/intel/cannonlake
The CPUs are Coffee Lake, though. They are not Amber Lake.
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52693/comment/53e4c764_fa4dda05
PS5, Line 314: COFFEELAKE
AMBERLAKE
The CPUs are not Amber Lake.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52693
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I479c648e40c4c607d29f8cdd913fdbd6d7d7d991
Gerrit-Change-Number: 52693
Gerrit-PatchSet: 5
Gerrit-Owner: Timofey Komarov
happycorsair@yandex.ru
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Timofey Komarov
happycorsair@yandex.ru
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 30 Apr 2021 08:22:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment