24 Oct
2022
24 Oct
'22
8:45 a.m.
Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68489 )
Change subject: soc/mediatek/mt8188: Update mtcmos settings for display and audio ......................................................................
Patch Set 7:
(1 comment)
File src/soc/mediatek/mt8188/mtcmos.c:
https://review.coreboot.org/c/coreboot/+/68489/comment/93d3de61_7a66cf37 PS7, Line 10: if (pd->caps & SCPD_EXT_BUCK_ISO) How about moving the `if` conditional to `mtcmos_power_on()`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68489
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f00bda0cc5c7f8dea55a564a0ff10ae601115b3
Gerrit-Change-Number: 68489
Gerrit-PatchSet: 7
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 06:45:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment