[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: don't apply unconfigured USB2 PHY tune parameters

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43781 )

Change subject: soc/amd/picasso: don't apply unconfigured USB2 PHY tune parameters
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43781/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43781/1//COMMIT_MSG@11 
PS1, Line 11: configured in the board's devicetree. Since all parameters being zero is
> Defaults can change. […]

I do agree that just using defaults and hoping for the best isn't good practice and that boards should use optimized values. Found a problem with the next patch in the patch train anyway that prevents us from using the defaults, so I'll just convert the devicetree settings to the changed format in the patch that reworks the data structures and handling.

Surprisingly having everything set to 0 didn't break USB2 on mandolin.