Attention is currently required from: Sean Rhodes, SRIDHAR SIRICILLA, Tim Wawrzynczak, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67760 )
Change subject: soc/intel/common: Remove the option to send EOP early
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
@subrata Any feedback on this? Or could we merge PS:1 as to avoid problems in master?
I agree with just PS1 and we can work together with Intel to get the recommendations around sending EOP early. If seems not required, we can always drop that later.
File src/soc/intel/alderlake/chip.c:
https://review.coreboot.org/c/coreboot/+/67760/comment/db65a314_284fa0f9
PS1, Line 207: 0)
can we use the macro instead `0` to define the ME state?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cdb97474ba0f37bf61f22d72cd3cc840f817652
Gerrit-Change-Number: 67760
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: SRIDHAR SIRICILLA
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 03:55:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment