[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/pantherlake: Update Touch Controller UPD params

[Jérémy Compostella (Code Review)]

Attention is currently required from: Bora Guvendik, Cliff Huang, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Pranava Y N, Subrata Banik.

Jérémy Compostella has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85199?usp=email )

Change subject: soc/intel/pantherlake: Update Touch Controller UPD params
......................................................................

Patch Set 7:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85199/comment/fc7a0a07_f2d2125d?usp... :
PS5, Line 9: :
> Not needed.

Done

https://review.coreboot.org/c/coreboot/+/85199/comment/029699ac_f63be060?usp... :
PS5, Line 9: ThcAssignment
> ThcAssignment was already set before?

Done

https://review.coreboot.org/c/coreboot/+/85199/comment/a27454a3_9114aa99?usp... :
PS5, Line 12: modified:   src/soc/intel/pantherlake/chip.h
            : 	modified:   src/soc/intel/pantherlake/fsp_params.c
> Not needed, as the Gerrit interface and `git show --stat` show this.

Done

File src/soc/intel/pantherlake/chip.h:

https://review.coreboot.org/c/coreboot/+/85199/comment/1b3deed4_12a486bf?usp... :
PS5, Line 517: /* Touch Host Controller Mode
             : 	 * Switch between Intel THC protocol and Industry standard HID Over SPI protocol.
             : 	 * 0x0:Thc, 0x1:Hid, 0x2:I2c
             : 	 */
             : 	uint8_t thc_mode[2];
             : 
             : 	/* Touch Host Controller Wake On Touch
             : 	 * Based on this setting vGPIO for given THC will be in native mode, and additional
             : 	 * _CRS for wake will be exposed in ACPI
             : 	 */
> Please use the recommended multi-line comment styles. […]

Done

https://review.coreboot.org/c/coreboot/+/85199/comment/37179fd8_1982fe9b?usp... :
PS5, Line 527: 	uint8_t thc_wake_on_touch[2];
> Why not bool?

Done