[coreboot-gerrit] [M] Change in coreboot[main]: mb/trulo/var/uldrenite: Enable DPTF, S0ix and configure FIVR setting

[John Su (Code Review)]

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.

John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85578?usp=email )

Change subject: mb/trulo/var/uldrenite: Enable DPTF, S0ix and configure FIVR setting
......................................................................

Patch Set 3:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85578/comment/3c06e490_1921743f?usp... :
PS2, Line 7: Power management and external Settings
> Please make it a statement. For example: […]

Done

https://review.coreboot.org/c/coreboot/+/85578/comment/21e64a4e_d53dbb5a?usp... :
PS2, Line 9: dptf
> DPTF

Done

https://review.coreboot.org/c/coreboot/+/85578/comment/aa779f3d_1b1dcf8f?usp... :
PS2, Line 10: s0ix
> S0ix

Done

https://review.coreboot.org/c/coreboot/+/85578/comment/f3ff74e5_037dae33?usp... :
PS2, Line 9: 1. Enable dptf
           : 2. Enable s0ix
           : 3. Configure external fivr setting
> Enumerating items is always a good indicator, that the commit should be split up in smaller pieces.

Acknowledged

https://review.coreboot.org/c/coreboot/+/85578/comment/f77f76d6_f6861a77?usp... :
PS2, Line 14: TEST=emerge-nissa coreboot
> Do you have access to the device already?

Not yet, these are initial value settings based on the reference design and the experience of our other teams.

File src/mainboard/google/brya/variants/uldrenite/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/85578/comment/a4156c55_d2220271?usp... :
PS2, Line 85: #DPTF
> Add a space after #?

Done