[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead

[Tim Van Patten (Code Review)]

Attention is currently required from: John Su, Jason Nien, Jon Murphy, Jason Glenesk, Chris Wang, Martin Roth, Karthik Ramasubramanian, Felix Held.

Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74583 )

Change subject: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead
......................................................................

Patch Set 3:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/74583/comment/ea554a72_7ae9b9b2 
PS3, Line 7: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead
We should update Whiterun as well, to prevent hitting similar issues there, assuming the eMMC is more accurate.

File src/mainboard/google/skyrim/variants/markarth/port_descriptors.c:

https://review.coreboot.org/c/coreboot/+/74583/comment/720100f1_f2928b1a 
PS3, Line 88: 	if (gpio_get(EMMC_CLKREQ_GPIO)) {
Whiterun uses this same query, but is not being fixed with this CL.

Is it possible to create a `get_storage_type()` function in `variants/baseboard/gpio.c`, which unifies the GPIO checking and can be called here? The return type would be an `enum` that includes EMMC, NVME, and can be extended to anything else that's supported.

That would also prevent redefining `EMMC_CLKREQ_GPIO` here.