Attention is currently required from: Bora Guvendik, Anil Kumar K, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Thejaswani Putta. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61354 )
Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support ......................................................................
Patch Set 10:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61354/comment/ffe6520c_37962c84 PS10, Line 11:
It would be good to mention the explicit dependency on having a […]
will add:
build dependency: soc/intel/common/block/pcie/rtd3
This driver will use the rtd3 methods for the same parent in the device tree. The rtd3 chip needs to be added on the same root port in the devicetree separately.
File src/drivers/wwan/fm/Kconfig:
https://review.coreboot.org/c/coreboot/+/61354/comment/5d0d254f_8ab331ab PS10, Line 9:
Right now there is an explicit dependency on also having a […]
Yes. it depends on rtd3 chip to be selected to build this driver. it is supposed to point to the same rtd3 chip driver on the same parent for the rtd3 method provided only from this particular instance. This driver does not need to know about its root port number, or it is on CPU or PCH root port. when it calls rtd3 methods, the rtd3 drive takes care of root port specific.
File src/drivers/wwan/fm/acpi_fm350gl.c:
https://review.coreboot.org/c/coreboot/+/61354/comment/b3690b61_3006d1d2 PS10, Line 103: : /* : Generate second half reset flow (SHRF) method. : */
will fix.
File src/drivers/wwan/fm/chip.h:
https://review.coreboot.org/c/coreboot/+/61354/comment/02f0e006_fe774272 PS10, Line 21: RTD3
It points to the RP right? maybe: […]
This needs to point to the chip soc/intel/common/block/pcie/rtd3 on the same root port. This is passed so it can reference to rtd3 config for the 'ext_pm_support'.
Please also see the https://review.coreboot.org/c/coreboot/+/61355 for how it is referenced.