Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37214 )
Change subject: lib: Fix FMAP cache on FSP1.0 platforms ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37214/1/src/lib/fmap.c File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/37214/1/src/lib/fmap.c@123 PS1, Line 123: destroyed on FspMemoryInit() exit.
perhaps wording is incorrect. yeah they are relocated, but CAR is torn down. We cache only mem_region_device, but the payload is located in CAR region that is not CAR variable on its own. So mem_region_device has an invalid wild pointer after fspmemoryinit
Ah I see. The mem rdev region is just not valid anymore. Thx for explaining. What do you think about the following wording: "On FSP1.0 platforms the CAR content is destroyed and relocated. Instead of updating the memory region device holding the cache, work around this by reading FMAP from flash after FspMemoryInit()."