Attention is currently required from: Jakub Czapiga, Paul Fagerburg, Julius Werner, Jan Dabros. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58327 )
Change subject: libpayload/tests: Add libcbfs/cbfs_core-test test case ......................................................................
Patch Set 2:
(5 comments)
File payloads/libpayload/tests/libcbfs/cbfs_core-test.c:
https://review.coreboot.org/c/coreboot/+/58327/comment/31b01626_16aa9deb PS2, Line 245: fail() Is fail a function?
https://review.coreboot.org/c/coreboot/+/58327/comment/d7822edb_8a23873b PS2, Line 487: test_cbfs_get_handle_file_bigger_than_cbfs Could you explain the purpose of this test?
https://review.coreboot.org/c/coreboot/+/58327/comment/a450c6ff_a13279d2 PS2, Line 580: * Space
https://review.coreboot.org/c/coreboot/+/58327/comment/5a842337_4a7c723d PS2, Line 672: sizeof(struct cbfs_file) + 16 handle->attribute_offset
https://review.coreboot.org/c/coreboot/+/58327/comment/dcbc4840_ca19b9fc PS2, Line 773: assert_null(cbfs_get_contents(handle, &size, 0)); After this call, reset size to 0 for the second call.