Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Maximilian Brune, Nico Huber, Patrick Rudolph, Sean Rhodes, Werner Zeh.
Angel Pons has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/74121?usp=email )
Change subject: drivers/option: Add forms in cbtables
......................................................................
Patch Set 29:
(1 comment)
File src/commonlib/include/commonlib/cfr.h:
https://review.coreboot.org/c/coreboot/+/74121/comment/223f540b_75abbe6b?usp... :
PS27, Line 143: uint32_t tag; /* CFR_TAG_OPTION_VARCHAR */
: uint32_t size;
: uint64_t object_id; /* Uniqueue ID */
: uint64_t dependency_id; /* Grayout if value of lb_cfr_numeric_option with given ID is 0.
: * Ignore if field is 0.
: */
: uint32_t flags; /* enum cfr_option_flags */
Is this a nit? I am not sure how to do it, and i think current implementation is fine?
It's a "I will take care of it myself in a follow-up"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74121?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772
Gerrit-Change-Number: 74121
Gerrit-PatchSet: 29
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Daniel Maslowski
info@orangecms.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 17 Dec 2024 17:58:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com