Tom Hiller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44510 )
Change subject: Intel GBE 82579LM bincfg set and spec ......................................................................
Patch Set 3:
Patch Set 2: Code-Review+1
(1 comment)
Looks pretty good to me, did you test this by comparing what it generated to your actual GbE? If it was identical, we can probably merge this, or if it wasn't identical did you test on hw?
I tested it against the stock GBE and tested it on a X220. There are a few variations between this and the stock GBE, I used Intel defaults with the exception of the LEDs and disabling the same menus that were disabled in the x200 set.
There are also two regions not specified by the data sheet in the stock GBE, one is between offset 0x00A9-0x00E7 and the second is 0x0200-0x0583. I assume these are blobs related to Boot Agent.