Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59390 )
Change subject: soc/intel/../thermal: Drop unused `dev` variable in pch_get_ltt_value()
......................................................................
Patch Set 1: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59390/comment/f3f51cd5_8e6d2580
PS1, Line 7: variable
parameter
https://review.coreboot.org/c/coreboot/+/59390/comment/4aaffd27_ceef72e8
PS1, Line 9: being
nit: move to next line
https://review.coreboot.org/c/coreboot/+/59390/comment/7b216c8e_81d66438
PS1, Line 10: replaced
present tense (no final `d`): `replace`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecdf6f6c3023f896a27e212d7c59b2030a3fd116
Gerrit-Change-Number: 59390
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 17 Nov 2021 14:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment