Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35365 )
Change subject: emulation/qemu-i440fx: use fw_cfg_dma for fw_cfg_read ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35365/2/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/35365/2/src/mainboard/emulation/qem... PS2, Line 529: dma_desc_addr = (uint32_t)&dma;
that doesn't work on x86_64. Please write FW_CFG_DMA_ADDR_HIGH as well.
Done
https://review.coreboot.org/c/coreboot/+/35365/2/src/mainboard/emulation/qem... PS2, Line 532: asm("");
should work without asm("").
Done
https://review.coreboot.org/c/coreboot/+/35365/3/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/35365/3/src/mainboard/emulation/qem... PS3, Line 532: dma_desc_addr_hi = sizeof(uintptr_t) > sizeof(uint32_t) ? (uint32_t)(dma_desc_addr >> 32) : 0;
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/35365/3/src/mainboard/emulation/qem... PS3, Line 538:
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/35365/3/src/mainboard/emulation/qem... PS3, Line 539: while (be32_to_cpu(dma.control) & ~FW_CFG_DMA_CTL_ERROR);
trailing statements should be on next line
Ack
https://review.coreboot.org/c/coreboot/+/35365/3/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/fw_cfg_if.h:
https://review.coreboot.org/c/coreboot/+/35365/3/src/mainboard/emulation/qem... PS3, Line 84: char name[FW_CFG_MAX_FILE_PATH];
please, no spaces at the start of a line
Done