[coreboot-gerrit] Change in ...coreboot[master]: mainboard/google/coral: power off EN_PP3300_DX_LTE_SOC when entering S5

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22415 )

Change subject: mainboard/google/coral: power off EN_PP3300_DX_LTE_SOC when entering S5
......................................................................

Patch Set 2:
> Patch Set 2:
>
> How do you verify if mainboard_smi_sleep() function is getting called in reboot cycle or not?
> we are seeing issue in hatch where modem is asking for PIN in reboot and mainboard_smi_sleep() function can't get call in reboot path. But if we drive required modem GPIO to low in reboot path (somehow) and its working fine, almost similar way how you have done in S5. But problem is that you have added this code inside Sleep handler which won't get called for reboot.

[Subrata] fixing typo

"where modem is not asking for PIN in reboot "