[coreboot-gerrit] Change in coreboot[master]: soc/intel/jasperlake: Enables CSE Lite driver for JSL platform in the...

[Sridhar Siricilla (Code Review)]

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48280 )

Change subject: soc/intel/jasperlake: Enables CSE Lite driver for JSL platform in the romstage
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48280/2/src/soc/intel/jasperlake/ro... 
File src/soc/intel/jasperlake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/48280/2/src/soc/intel/jasperlake/ro... 
PS2, Line 138: 	if (!s3wake)
> I think it is safe to do the call to cse_fw_sync() before save_dimm_info() and also restrict the cal […]

Ack

https://review.coreboot.org/c/coreboot/+/48280/2/src/soc/intel/jasperlake/ro... 
PS2, Line 142: cse_fw_sync();
> I wonder if we should add dram_init_done_hooks just like we have cbmem_init_hooks. […]

Agree, I will explore the suggested method..