Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Pranava Y N, Ronak Kanabar, Tarun.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84356?usp=email )
Change subject: drivers/intel/fsp2_0: Define 64-bit FSP_STATUS_GLOBAL_RESET ......................................................................
Patch Set 2:
(4 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/84356/comment/188a11b7_ed627a77?usp... : PS2, Line 378: 0x4000000000000003 can you please point me to the FSP spec that defines 64-bit FSP return value.
Ideally they should be used below logic to covert into 64-bit if required
``` #define CONVERT_TO_64BIT(value) (CONFIG_PLATFORM_USES_FSP2_X86_32 \ ? value : \ ((uint64_t)(value & 0xf0000000) << 32) | (value & 0xff))
#define FSP_STATUS_WRAPPER(x) CONVERT_TO_64BIT(x) ```
File src/include/efi/efi_datatype.h:
https://review.coreboot.org/c/coreboot/+/84356/comment/6e3a1164_dd65ee06?usp... : PS2, Line 16: #if CONFIG(PLATFORM_USES_FSP1_1) || CONFIG(PLATFORM_USES_FSP2_X86_32) can u please submit a separate CL to add FSP1.1 if required
File src/soc/intel/meteorlake/chip.c:
https://review.coreboot.org/c/coreboot/+/84356/comment/fb75d43b_08ba28cc?usp... : PS2, Line 276: fsp_die_with_post_code(reset_status, POSTCODE_HW_INIT_FAILURE, : "Failed to handle the FSP reset request"); please submit a separate CL for this as well
File src/soc/intel/pantherlake/chip.c:
https://review.coreboot.org/c/coreboot/+/84356/comment/02ce52d6_f9f5a5ae?usp... : PS2, Line 274: fsp_die_with_post_code(reset_status, POSTCODE_HW_INIT_FAILURE, : "Failed to handle the FSP reset request"); same as previous file