[coreboot-gerrit] Change in ...coreboot[master]: mb/google/sarien: add ish firmware_variant field to _DSD

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants... 
File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants... 
PS8, Line 213: 						device usb 2.0 on end
> I agree that is seems inverted. It was initially confusing to me. […]

The keyword 'chip' has confused me many times and causes strange nesting/indenting in these devicetree.cb files, while the generated mb/static.c files are ok. That 'chip' could be an attribute inside the 'device usb 2.0' block on our sconfig syntax.

And yes, this is not limited to USB at all. This is just closely coupled with source tree layout that implies 'one chip.h one info structure'.