William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee...
PS4, Line 16: USB3_PORT_EMPTY
Just curious: No USB3 ports for C1 and C0?
C0 and C1 port attached the processor XHCI USB3, device tree here only define the PCH XHCI USB3.
So it seems a little strange.
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee...
PS4, Line 22:
nit: use tabs instead of spaces here and in the lines below.
Done, many thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ce465705e8b8f67ddbc9e4eb06c5a8bfac65fcb
Gerrit-Change-Number: 42246
Gerrit-PatchSet: 5
Gerrit-Owner: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hao He
hao.he@bitland.corp-partner.google.com
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-CC: Xiong Huang
xiong.huang@bitland.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Jun 2020 02:09:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment