Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42566 )
Change subject: util/amdfwtool: Add support for EFS SPI values for F17h and F15h
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42566/5/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/42566/5/util/amdfwtool/amdfwtool.c@...
PS5, Line 430: typedef
ugh, I hate typedefs.
https://review.coreboot.org/c/coreboot/+/42566/5/util/amdfwtool/amdfwtool.c@...
PS5, Line 1238:
Can you clang-format?
https://review.coreboot.org/c/coreboot/+/42566/5/util/amdfwtool/amdfwtool.c@...
PS5, Line 1645: set_efs_table
Don't we want to returns some kind of error so the build fails?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87c4d44183ca65a5570de5e0c7f9b44aa6dd82f9
Gerrit-Change-Number: 42566
Gerrit-PatchSet: 5
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Jul 2020 21:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
