Attention is currently required from: Furquan Shaikh, Subrata Banik, Angel Pons, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58062 )
Change subject: soc/intel/common/../cse: Avoid caching of CSE BAR
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/58062/comment/9163937e_b53dfd7e
PS2, Line 69: void *
Agreed as good practice. […]
Good catch! that one is one of those that GCC lets through because it has special support. There are probably more these, I can try to poke around some more and hunt more down.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4ecc9006d6323b7c9d7a6af1afa5cfe63d933e5
Gerrit-Change-Number: 58062
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 01 Oct 2021 18:44:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment