Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42337 )
Change subject: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig
......................................................................
Patch Set 1:
Oh, yeah, you can't submit this until the FSP binaries have been pushed to amd_blobs. That's why we have it in the .configs
Humm... looks like jenkins is running abuild with -B option which turns ADD_FSP_BINARIES on by default.
That's probably unintentional. ADD_FSP_BINARIES is implied by the
USE_FSP_REPO option now, so there is no need to force it in this
case. And AFAIK, there is no other public place for Intel FSP
binaries.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1db5e1a53afb9eb2d2bf200f8e806160014e06c
Gerrit-Change-Number: 42337
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 21 Jun 2020 13:31:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment