Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73121 )
Change subject: mb/google/rex: Set audio GPIOs based on fw_config
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/mainboard/google/rex/variants/rex0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/73121/comment/5add1e71_84f2741a
PS5, Line 9: #define GPIO_PADBASED_OVERRIDE(b, a) gpio_padbased_override(b, a, ARRAY_SIZE(a))
nice macro
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73121
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ed452a0d08e6779add318d9bbd1e97b50b6aea9
Gerrit-Change-Number: 73121
Gerrit-PatchSet: 5
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 22 Feb 2023 00:47:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment