Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44270 )
Change subject: soc/intel/jasperlake: Disable IPU based on devicetree
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44270/6/src/soc/intel/jasperlake/ro...
File src/soc/intel/jasperlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/44270/6/src/soc/intel/jasperlake/ro...
PS6, Line 70: /* By default IPU is enabled, need to disable in FSP if pci device is disabled */
nit: not needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f9a40e85427fd88bb12a40770ecf7b939b1d8cd
Gerrit-Change-Number: 44270
Gerrit-PatchSet: 6
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Aug 2020 09:40:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment