Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31950 )
Change subject: device/pciexp_device: Add set_subsystem() for pciexp device ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31950/2/src/include/device/pciexp.h File src/include/device/pciexp.h:
https://review.coreboot.org/#/c/31950/2/src/include/device/pciexp.h@6 PS2, Line 6: #define PCIE_SUBSYSTEM_VENDOR_ID 0x94
Ah.. […]
yes, subsystem programming register is eventually different between PCI and PCIE. And i could see PCI devices are still cover using common name but i thought you are explicit about PCIE as i knew in past that there are no any common PCIE subsystem programming, hence thought of creating dedicated one for PCIE and refer it across.
Actually i was thinking i don't even need to declare PCIE_SUBSYSTEM_VENDOR_ID in .h as no one going to use the same from .h explicitly